Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linux): include border and titlebars in Window::{outer_position, outer_size} and WindowEvent::Moved event #1001

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(linux): include border and titlebars in Window::{outer_position, outer_size} and WindowEvent::Moved event #1001

wants to merge 3 commits into from
+120 −85

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir requested a review from a team as a code owner October 30, 2024 11:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Package Changes Through 81694aa

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.30.5 0.30.6

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir marked this pull request as draft October 30, 2024 12:22
@amrbashir amrbashir marked this pull request as ready for review October 30, 2024 12:40
@amrbashir amrbashir changed the title fix(linux): include border and titlebars in Window::outer_position fix(linux): include border and titlebars in Window::{outer_position, outer_size} and WindowEvent::Moved event Oct 30, 2024
pewsheen
pewsheen approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@pewsheen pewsheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Ubuntu 24.04 with Wayland

btw, I found the doc of WindowEvent::Moved and outer_position says Wayland will always return (0,0), but it seems that it returns the actual position on my end.

@amrbashir
Copy link
Member Author

Tested on my Ubuntu 24.04 with Wayland

btw, I found the doc of WindowEvent::Moved and outer_position says Wayland will always return (0,0), but it seems that it returns the actual position on my end.

Make sure you're running under Wayland, launching the example from within vscode usually runs the window under x11 even if the session is Wayland.

@pewsheen
Copy link
Contributor

pewsheen commented Nov 1, 2024

Tested on my Ubuntu 24.04 with Wayland
btw, I found the doc of WindowEvent::Moved and outer_position says Wayland will always return (0,0), but it seems that it returns the actual position on my end.

Make sure you're running under Wayland, launching the example from within vscode usually runs the window under x11 even if the session is Wayland.

Oh, you're right. I was running from the vscode and it runs on X11 actually

@dgerhardt dgerhardt mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pewsheen pewsheen pewsheen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Getting outer position of window on Ubuntu ignores caption and borders
2 participants
@amrbashir @pewsheen